152
League of Ancients smart contract security audit report performed by Callisto Security Audit Department
- Smart Contract info : https://docs.google.com/document/d/1Obi4nCMnSF3Ji3aBWW-r0k0ZTysZYe2mFMwPuX3kMBM/edit
- Token Unlock Schedule : https://docs.google.com/spreadsheets/d/1S25D8yl6l0J9ZHHpFxeYfmuTFv6iUQuwqPec27Q7JWk/edit#gid=93878185
- https://leagueofancients.com
- @loaofficialmoba
Source code
https://gitlab.com/jingyi2811/luo/-/tree/main/original-contracts
Disclosure policy
Standard disclosure policy
Binance Smart Chain.
1. In scope
ef025a4498362ccd65af62ff81a2f38a2b2abd1b
1.1. Excluded
The schedule correctness of tokens distribution was excluded from audit.
2. Findings
In total, were reported including:
- 0 high severity issues.
- 0 medium severity issue.
- 0 low severity issue.
In total, were reported, including:
- 5 owner privileges.
No critical security issues were found.
2.1 Admin privileges
Severity: owner privileges.
Description:
LoaToken contract Admin can:
- 1. Pause/unpause token transfer.
- 2. Pause/unpause token transfer for selected address.
LoaPresale contracts Admin can:
- 3. Add/remove addresses to/from whitelist.
- 4. Withdraw deposited BNB.
- 5. Finish
LoaPresale
3. Security practices
Open-source contact.
The contract should pass a bug bounty after the completion of the security audit.
Public testing.
Automated anomaly detection systems. – NOT IMPLEMENTED. A simple anomaly detection algorithm is recommended to be implemented to detect behavior that is atypical compared to normal for this contract. For instance, the contract must halt deposits in case a large amount is being withdrawn in a short period of time until the owner or the community of the contract approves further operations.
Multisig owner account.
Standard ERC20-related issues. – NOT IMPLEMENTED. It is known that every contract can potentially receive an unintended ERC20-token deposit without the ability to reject it even if the contract is not intended to receive or hold tokens. As a result, it is recommended to implement a function that will allow extracting any arbitrary number of tokens from the contract.
Crosschain address collisions. ETH, ETC, CLO, etc. It is possible that a transaction can be sent to the address of your contract at another chain (as a result of a user mistake or some software fault). It is recommended that you deploy a “mock contract” that would allow you to withdraw any tokens from that address or prevent any funds deposits. Note that you can reject transactions of native token deposited, but you can not reject the deposits of ERC20 tokens. You can use this source code as a mock contract: extractor contract source code. The address of a new contract deployed using CREATE (0xf0)opcode is assigned following this scheme keccak256(rlp([sender, nonce])). Therefore you need to use the same address that was originally used at the main chain to deploy the mock contract at a transaction with the that matches that on the original chain.
Example:If you have deployed your main contract with address 0x010101 at your 2021th transaction then you need to increase your nonce of 0x010101 address to 2020 at the chain where your mock contract will be deployed. Then you can deploy your mock contract with your 2021th transaction, and it will receive the same address as your main net contract.
4. Conclusion
The audited smart contract can be deployed. No security issues were found during the audit.
It is recommended to adhere to the security practices described in pt. 4 of this report to ensure the contract’s operability and prevent any issues that are not directly related to the code of this smart contract.
Appendix
Smart Contract Audits by Callisto Network.
Miscellaneous
Why Audit Smart Contracts?
Our Most Popular Audit Reports.
